[DO_NOT_MERGE][INFRA] test dockerfile #41918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
reviewed
Jul 10, 2023
| @@ -55,10 +55,9 @@ RUN $APT_INSTALL r-base libcurl4-openssl-dev qpdf libssl-dev zlib1g-dev | |||
| RUN Rscript -e "install.packages(c('knitr', 'markdown', 'rmarkdown', 'testthat', 'devtools', 'e1071', 'survival', 'arrow', 'roxygen2', 'xml2'), repos='https://cloud.r-project.org/')" | |||
|
|
|||
| # See more in SPARK-39959, roxygen2 < 7.2.1 | |||
| RUN apt-get install -y libcurl4-openssl-dev libgit2-dev libssl-dev libxml2-dev \ | |||
| RUN apt-get install -y libgit2-dev libssl-dev libxml2-dev \ | |||
There was a problem hiding this comment.
We need to add apt update in here:
- L1-L57 are using cache layers
- L58 changed, so that will reinstall but still use the old apt update results (L37), so CI failed.
There was a problem hiding this comment.
thanks let me have a try.
But if we add apt update here, does it means that the cache will be disabled from L58?
There was a problem hiding this comment.
The cache will be invalidated if you change the line. the apt update is only to refresh ubuntu package list (local copy).
zhengruifeng
force-pushed
the
test_docker_file
branch
from
b8d4573 to
87adbc8
Compare
zhengruifeng
added a commit
that referenced
this pull request
Sep 13, 2023
### What changes were proposed in this pull request? follow the [Best practices for writing Dockerfiles](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get) : > Always combine RUN apt-get update with apt-get install in the same RUN statement. ### Why are the changes needed? 1, to address #42253 (comment) 2, when I attempted to change the apt-get install in #41918, the behavior was confusing. By following the best practices, further changes should work immediately. ### Does this PR introduce _any_ user-facing change? NO, dev-only ### How was this patch tested? CI ### Was this patch authored or co-authored using generative AI tooling? NO Closes #42842 from zhengruifeng/infra_docker_file_opt. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?