[SPARK-43356][K8S] Migrate deprecated createOrReplace to serverSideApply #41136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
How many PRs do you want to make, @pan3793 ? Actually, we don't need to follow deprecation eagerly if there is no planned deletion.
No overall estimation, I have been working on this area recently, and would like to propose change when I find something has room for improvement. |
|
Then, let's hold on this PR for a while because we don't need to take any risk. |
|
We are now using |
|
rebased on the latest master branch |
|
Looks reasonable to me pending @dongjoon-hyun's review |
czxm
pushed a commit
to czxm/spark
that referenced
this pull request
Jun 12, 2023
### What changes were proposed in this pull request?
The deprecation message of `createOrReplace` indicates that we should change `createOrReplace` to `serverSideApply` instead.
```
deprecated please use {link ServerSideApplicable#serverSideApply()} or attempt a create and edit/patch operation.
```
The change is not fully equivalent, but I believe it's reasonable.
> With the caveat that the user may choose not to use forcing if they want to know when there are conflicting changes.
>
> Also unlike createOrReplace if the resourceVersion is set on the resource and a replace is attempted, it will be optimistically locked.
See more details at fabric8io/kubernetes-client#5073
### Why are the changes needed?
Remove usage of deprecated API.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
Closes apache#41136 from pan3793/SPARK-43356.
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The deprecation message of
createOrReplaceindicates that we should changecreateOrReplacetoserverSideApplyinstead.The change is not fully equivalent, but I believe it's reasonable.
See more details at fabric8io/kubernetes-client#5073
Why are the changes needed?
Remove usage of deprecated API.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.