[SPARK-34737][SQL] Cast input float to double in TIMESTAMP_SECONDS
#31831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
@HyukjinKwon @cloud-fan @yaooqinn @gengliangwang Could you review this PR, please. |
yaooqinn
approved these changes
Mar 14, 2021
|
LGTM~ |
HyukjinKwon
approved these changes
Mar 15, 2021
|
Merged to master. |
|
I would like to backport this to |
MaxGekk
added a commit
to MaxGekk/spark
that referenced
this pull request
Mar 17, 2021
In the PR, I propose to cast the input float to double in the `SecondsToTimestamp` expression in the same way as in the `Cast` expression. To have the same results from `CAST(<float> AS TIMESTAMP)` and from `TIMESTAMP_SECONDS`: ```sql spark-sql> SELECT CAST(16777215.0f AS TIMESTAMP); 1970-07-14 07:20:15 spark-sql> SELECT TIMESTAMP_SECONDS(16777215.0f); 1970-07-14 07:20:14.951424 ``` Yes. After the changes: ```sql spark-sql> SELECT TIMESTAMP_SECONDS(16777215.0f); 1970-07-14 07:20:15 ``` By running new test: ``` $ build/sbt "test:testOnly *DateExpressionsSuite" ``` Closes apache#31831 from MaxGekk/adjust-SecondsToTimestamp. Authored-by: Max Gekk <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 7aaed76) Signed-off-by: Max Gekk <[email protected]>
|
Here is the backport to 3.1: #31872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to cast the input float to double in the
SecondsToTimestampexpression in the same way as in theCastexpression.Why are the changes needed?
To have the same results from
CAST(<float> AS TIMESTAMP)and fromTIMESTAMP_SECONDS:Does this PR introduce any user-facing change?
Yes. After the changes:
How was this patch tested?
By running new test: