SPARK-1350. Always use JAVA_HOME to run executor container JVMs. #313
Conversation
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Change looks good to me. Will wait to see if anyone else has comments. |
|
The running-on-yarn documentation has an example of using I'm guessing this is still valid because it somehow magically gets into Environment.JAVA_HOME, but I just want to make sure the docs are still up-to-date. |
|
That's still valid. Environment.JAVA_HOME is just the string literal "$JAVA_HOME". It gets placed inside the container launch script, so an overridden value for JAVA_HOME specified in SPARK_YARN_USER_ENV will still take effect. |
|
Great, well, no further comments here. Feel free to merge, Tom. |
|
I committed this. Thanks Sandy! |
Refactored the streaming project to separate external libraries like Twitter, Kafka, Flume, etc. At a high level, these are the following changes. 1. All the external code was put in `SPARK_HOME/external/` as separate SBT projects and Maven modules. Their artifact names are `spark-streaming-twitter`, `spark-streaming-kafka`, etc. Both SparkBuild.scala and pom.xml files have been updated. References to external libraries and repositories have been removed from the settings of root and streaming projects/modules. 2. To avail the external functionality (say, creating a Twitter stream), the developer has to `import org.apache.spark.streaming.twitter._` . For Scala API, the developer has to call `TwitterUtils.createStream(streamingContext, ...)`. For the Java API, the developer has to call `TwitterUtils.createStream(javaStreamingContext, ...)`. 3. Each external project has its own scala and java unit tests. Note the unit tests of each external library use classes of the streaming unit tests (`TestSuiteBase`, `LocalJavaStreamingContext`, etc.). To enable this code sharing among test classes, `dependsOn(streaming % "compile->compile,test->test")` was used in the SparkBuild.scala . In the streaming/pom.xml, an additional `maven-jar-plugin` was necessary to capture this dependency (see comment inside the pom.xml for more information). 4. Jars of the external projects have been added to examples project but not to the assembly project. 5. In some files, imports have been rearrange to conform to the Spark coding guidelines.
Author: Sandy Ryza <[email protected]> Closes apache#313 from sryza/sandy-spark-1350 and squashes the following commits: bb6d187 [Sandy Ryza] SPARK-1350. Always use JAVA_HOME to run executor container JVMs.
No description provided.