Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][MLLIB] fix seed in BaggedPointSuite #3084

Closed
wants to merge 1 commit into from
Closed

[FIX][MLLIB] fix seed in BaggedPointSuite #3084

wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 4, 2014

Saw Jenkins test failures due to random seeds.

@jkbradley @manishamde

@SparkQA
Copy link

SparkQA commented Nov 4, 2014

Test build #22839 has started for PR 3084 at commit f735a43.

  • This patch merges cleanly.

@manishamde
Copy link
Contributor

@mengxr Sorry, it's my fault. It looks good to me.

@jkbradley
Copy link
Member

LGTM

@SparkQA
Copy link

SparkQA commented Nov 4, 2014

Test build #22839 has finished for PR 3084 at commit f735a43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NullType(PrimitiveType):
    • // in some cases, such as when a class is enclosed in an object (in which case
    • case class ScalaUdfBuilder[T: TypeTag](f: AnyRef)
    • abstract class UserDefinedType[UserType] extends DataType with Serializable
    • public abstract class UserDefinedType<UserType> extends DataType implements Serializable

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22839/
Test PASSed.

@mengxr
Copy link
Contributor Author

mengxr commented Nov 4, 2014

Merged into both master and branch-1.2.

@asfgit asfgit closed this in c5912ec Nov 4, 2014
asfgit pushed a commit that referenced this pull request Nov 4, 2014
@mengxr
[FIX][MLLIB] fix seed in BaggedPointSuite
0826eed 
Saw Jenkins test failures due to random seeds.

jkbradley manishamde

Author: Xiangrui Meng <[email protected]>

Closes #3084 from mengxr/fix-baggedpoint-suite and squashes the following commits:

f735a43 [Xiangrui Meng] fix seed in BaggedPointSuite

(cherry picked from commit c5912ec)
Signed-off-by: Xiangrui Meng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengxr @SparkQA @manishamde @jkbradley @AmplabJenkins