-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Test selective testing #2441
Conversation
merge upstream changes
merge upstream changes
merge upstream changes
QA tests have started for PR 2441 at commit
|
QA tests have started for PR 2441 at commit
|
This reverts commit 17505de.
Jenkins, retest this please. |
QA tests have started for PR 2441 at commit
|
Here are the Jenkins outputs for when:
Please confirm they look good. |
QA tests have finished for PR 2441 at commit
|
QA tests have finished for PR 2441 at commit
|
QA tests have finished for PR 2441 at commit
|
Overall I think this is better, thanks! One minor issue is that
Is there a reason for the difference in the 2 & 3? I think its okay to only run hive tests when catalyst, sql, or infrastructure (scripts, build files, etc) changes. Though I'll let others chime in here too. /cc @liancheng @JoshRosen |
No problem. Just give me an updated list of arguments to pass to
I'm not sure; I believe this was the behavior from before my patch. |
Just add
Sorry, I think I'm confused and this is actually correct as is. |
Addresses the problem pointed out in [this comment](apache#2441 (comment)).
Done in #2442. |
Addresses the problem pointed out in [this comment](#2441 (comment)). Author: Nicholas Chammas <[email protected]> Closes #2442 from nchammas/patch-1 and squashes the following commits: 7e68b60 [Nicholas Chammas] [SPARK-3534] Add hive-thriftserver to SQL tests
This is a dummy PR to test the work done in #2420 and #2437.
Do not merge it.