Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-26196][SPARK-26281][WebUI] Total tasks title in the stage page is incorrect when there are failed or killed tasks and update duration metrics #23160

Closed
wants to merge 3 commits into from
Closed

[SPARK-26196][SPARK-26281][WebUI] Total tasks title in the stage page is incorrect when there are failed or killed tasks and update duration metrics #23160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbd745a
Total tasks title in the stage page is incorrect
shahidki31 Nov 28, 2018
661566b
change duration as executorRunTime
shahidki31 Dec 1, 2018
5369a86
address comment
shahidki31 Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions core/src/main/resources/org/apache/spark/ui/static/stagepage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,8 @@ $(document).ready(function () {
$("#accumulator-table").DataTable(accumulatorConf);

// building tasks table that uses server side functionality
var totalTasksToShow = responseBody.numCompleteTasks + responseBody.numActiveTasks;
var totalTasksToShow = responseBody.numCompleteTasks + responseBody.numActiveTasks +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that makes sense. Looks good to me, however could you also please verify whether the data in tasks table reflects information about the failed / killed tasks as well, as I am passing the value of that variable in the ajax request while fetching data for task tables. Thank you for catching that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @pgandhi999 . All the failed tasks are displaying in the tasks table. Thanks for your great work.

responseBody.numKilledTasks + responseBody.numFailedTasks;
var taskTable = "#active-tasks-table";
var taskConf = {
"serverSide": true,
Expand Down Expand Up @@ -661,8 +662,8 @@ $(document).ready(function () {
{data : "launchTime", name: "Launch Time", render: formatDate},
{
data : function (row, type) {
if (row.duration) {
return type === 'display' ? formatDuration(row.duration) : row.duration;
if (row.taskMetrics && row.taskMetrics.executorRunTime) {
return type === 'display' ? formatDuration(row.taskMetrics.executorRunTime) : row.taskMetrics.executorRunTime;
Copy link

@pgandhi999 pgandhi999 Dec 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense. However, you also need to update the search filter method to not search on duration in StagesResource.scala here:

|| containsValue(f.duration.getOrElse(defaultOptionString))

https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala#L213.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks removed.

} else {
return "";
}
Expand Down Expand Up @@ -921,7 +922,7 @@ $(document).ready(function () {

// title number and toggle list
$("#summaryMetricsTitle").html("Summary Metrics for " + "<a href='#tasksTitle'>" + responseBody.numCompleteTasks + " Completed Tasks" + "</a>");
$("#tasksTitle").html("Task (" + totalTasksToShow + ")");
$("#tasksTitle").html("Tasks (" + totalTasksToShow + ")");

// hide or show the accumulate update table
if (accumulatorTable.length == 0) {
Expand Down
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ private[v1] class StagesResource extends BaseAppResource {
(containsValue(f.taskId) || containsValue(f.index) || containsValue(f.attempt)
|| containsValue(f.launchTime)
|| containsValue(f.resultFetchStart.getOrElse(defaultOptionString))
|| containsValue(f.duration.getOrElse(defaultOptionString))
|| containsValue(f.executorId) || containsValue(f.host) || containsValue(f.status)
|| containsValue(f.taskLocality) || containsValue(f.speculative)
|| containsValue(f.errorMessage.getOrElse(defaultOptionString))
Expand Down