[SPARK-25486][TEST] Refactor SortBenchmark to use main method #22495
Conversation
|
Test build #96361 has finished for PR 22495 at commit
|
|
Test build #96419 has finished for PR 22495 at commit
|
|
Test build #96441 has finished for PR 22495 at commit
|
|
Test build #96444 has finished for PR 22495 at commit
|
| */ | ||
| class SortBenchmark extends BenchmarkWithCodegen { | ||
| object SortBenchmark extends BenchmarkBase { |
There was a problem hiding this comment.
@yucai . BenchmarkWithCodegen is different from BenchmarkBase. Can we keep BenchmarkWithCodegen?
There was a problem hiding this comment.
@dongjoon-hyun SortBenchmark does not use any function provided in BenchmarkWithCodegen, so I remove it.
Another option is like #22484 did, make BenchmarkWithCodegen extend BenchmarkBase, and then SortBenchmark can extend BenchmarkWithCodegen.
Do you prefer the 2nd way?
BTW, congratulations! :)
There was a problem hiding this comment.
I got it. +1 for the current one. Thanks, @yucai .
|
Can one of the admins verify this patch? |
|
Merged to |
## What changes were proposed in this pull request? Refactor SortBenchmark to use main method. Generate benchmark result: ``` SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.SortBenchmark" ``` ## How was this patch tested? manual tests Closes apache#22495 from yucai/SPARK-25486. Authored-by: yucai <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
Refactor SortBenchmark to use main method.
Generate benchmark result:
How was this patch tested?
manual tests