-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-25339][TEST] Refactor FilterPushdownBenchmark #22443
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.util | ||
|
||
import java.io.{File, FileOutputStream, OutputStream} | ||
|
||
/** | ||
* A base class for generate benchmark results to a file. | ||
*/ | ||
abstract class BenchmarkBase { | ||
var output: Option[OutputStream] = None | ||
|
||
def benchmark(): Unit | ||
|
||
final def runBenchmark(benchmarkName: String)(func: => Any): Unit = { | ||
val separator = "=" * 96 | ||
val testHeader = (separator + '\n' + benchmarkName + '\n' + separator + '\n' + '\n').getBytes | ||
output.foreach(_.write(testHeader)) | ||
func | ||
output.foreach(_.write('\n')) | ||
} | ||
|
||
def main(args: Array[String]): Unit = { | ||
val regenerateBenchmarkFiles: Boolean = System.getenv("SPARK_GENERATE_BENCHMARK_FILES") == "1" | ||
if (regenerateBenchmarkFiles) { | ||
val resultFileName = s"${this.getClass.getSimpleName.replace("$", "")}-results.txt" | ||
val file = new File(s"benchmarks/$resultFileName") | ||
if (!file.exists()) { | ||
file.createNewFile() | ||
} | ||
output = Some(new FileOutputStream(file)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please address them when you fix some codes around here next time. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @HyukjinKwon. Will fix it next time. |
||
} | ||
|
||
benchmark() | ||
|
||
output.foreach { o => | ||
if (o != null) { | ||
o.close() | ||
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: try-catch and close it.