-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24054][R] Add array_position function / element_at functions #21130
[SPARK-24054][R] Add array_position function / element_at functions #21130
Conversation
cc @felixcheung, can you take a look please when you are available? |
443034a
to
7f75f5e
Compare
Test build #89729 has finished for PR 21130 at commit
|
Test build #89731 has finished for PR 21130 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
R/pkg/R/functions.R
Outdated
#' @param value A value to compute on. | ||
#' \itemize{ | ||
#' \item \code{array_contains}: a value to be checked if contained in the column. | ||
#' \item \code{array_position}: a value to to locate in the given array. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: to to
LGTM except for a tiny typo. |
Test build #89765 has finished for PR 21130 at commit
|
Merged to master. |
Thank you for reviewing this @felixcheung and @viirya. |
What changes were proposed in this pull request?
This PR proposes to add array_position and element_at in R side too.
array_position:
element_at:
How was this patch tested?
Unit tests were added in
R/pkg/tests/fulltests/test_sparkSQL.R
and manually tested. Documentation was manually built and verified.