Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[followup][SPARK-10399][SPARK-23879][Core] Free unused off-heap memory in MemoryBlockSuite #21117

Closed
wants to merge 1 commit into from

Conversation

kiszk
Copy link
Member

@kiszk kiszk commented Apr 20, 2018

What changes were proposed in this pull request?

As @viirya pointed out here, this PR explicitly frees unused off-heap memory in MemoryBlockSuite

How was this patch tested?

Existing UTs

@kiszk
Copy link
Member Author

kiszk commented Apr 20, 2018

cc @cloud-fan @viirya

@SparkQA
Copy link

SparkQA commented Apr 20, 2018

Test build #89655 has finished for PR 21117 at commit 2c1575d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member Author

kiszk commented Apr 21, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Apr 21, 2018

Test build #89668 has finished for PR 21117 at commit 2c1575d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@asfgit asfgit closed this in c3a86fa Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants