-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-3181][MLLIB]: Add Robust Regression Algorithm with Huber Estimator #2096
Conversation
A merge of latest changes since creation
Jenkins, test this please. |
Jenkins, add to whitelist. |
@fjiang6 Could you try LBFGS instead of SGD? |
QA tests have started for PR 2096 at commit
|
QA tests have finished for PR 2096 at commit
|
The failed test is "org.apache.spark.graphx.lib.TriangleCountSuite.Count two triangles", which is a part I never touched. What could be the possible reason for this failure? |
Jenkins, retest this please. This was a problematic commit in GraphX which I just reverted, so a retest should fix the problem. |
Can you please retest this? Thanks! |
Can you please retest this? Thanks! 发自我的 iPhone
|
ERROR: Timeout after 10 minutes Can you please retest? |
Jenkins, retest this please. |
QA tests have started for PR 2096 at commit
|
QA tests have finished for PR 2096 at commit
|
QA tests have started for PR 2096 at commit
|
QA tests have finished for PR 2096 at commit
|
I think this contribution may have "timed out", along with #2110 . They're probably good implementations, but I am not clear if this will be taken forward to be part of Spark. In any event it doesn't merge and is not necessarily written for the new ML pipelines API. Does anyone else have an opinion on whether this should be closed out, or needs to be revived? |
@fjiang6 in breeze we added ADMM based proximal minimizer and a proximal algorithm for Huber Loss...Could you please take a look at breeze.optimize.proximal.NonlinearMinimizer and Proximal.ProximalHuber and see if you can use NonlinearMinimizer ? Huber is as difficult as L1 (perhaps more difficult) since I have not seen a projection operator for Huber...For reference please follow Professor Boyd's paper on ADMM and Proximal Algorithms The jar is available on 0.12-SNAPSHOTS |
QA tests have started for PR 2096 at commit
|
QA tests have finished for PR 2096 at commit
|
Failed Tests: org.apache.spark.streaming.kafka.JavaKafkaStreamSuite.testKafkaStream |
QA tests have started for PR 2096 at commit
|
QA tests have finished for PR 2096 at commit
|
Huber Robust Regression including the test case and an example.
Passed the style checks