Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR][TEST] Fix class name for Pandas UDF tests #20489

Closed
wants to merge 2 commits into from
Closed

[MINOR][TEST] Fix class name for Pandas UDF tests #20489

wants to merge 2 commits into from

Conversation

icexelloss
Copy link
Contributor

@icexelloss icexelloss commented Feb 2, 2018 •
edited
Loading

What changes were proposed in this pull request?

In b2ce17b, I mistakenly renamed VectorizedUDFTests to ScalarPandasUDF. This PR fixes the mistake.

How was this patch tested?

Existing tests.

@icexelloss
Copy link
Contributor Author

cc @HyukjinKwon

@icexelloss icexelloss changed the title [MINOR][TEST] Fix test name for scalar pandas UDF tests [MINOR][TEST] Fix class name for scalar pandas UDF tests Feb 2, 2018
@icexelloss icexelloss changed the title [MINOR][TEST] Fix class name for scalar pandas UDF tests [MINOR][TEST] Fix class name for ScalarPandasUDFTests Feb 2, 2018
@SparkQA
Copy link

SparkQA commented Feb 2, 2018

Test build #87008 has finished for PR 20489 at commit 52498c0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ScalarPandasUDFTests(ReusedSQLTestCase):

@HyukjinKwon
Copy link
Member

Let's fix GroupbyApplyPandasUDFTests -> GroupedMapPandasUDFTests and GroupbyAggPandasUDFTests -> GroupedAggPandasUDFTests too.

@HyukjinKwon
Copy link
Member

gentle ping @icexelloss

@icexelloss icexelloss changed the title [MINOR][TEST] Fix class name for ScalarPandasUDFTests [MINOR][TEST] Fix class name for Pandas UDF tests Feb 6, 2018
@icexelloss
Copy link
Contributor Author

Sorry I was away for a few days. Should be good now.

@SparkQA
Copy link

SparkQA commented Feb 6, 2018

Test build #87116 has finished for PR 20489 at commit 442e2a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class GroupedMapPandasUDFTests(ReusedSQLTestCase):
  • class GroupedAggPandasUDFTests(ReusedSQLTestCase):

@gatorsmile
Copy link
Member

Thanks! Merged to master/2.3

@asfgit asfgit closed this in caf3044 Feb 6, 2018
asfgit pushed a commit that referenced this pull request Feb 6, 2018
@icexelloss @gatorsmile
[MINOR][TEST] Fix class name for Pandas UDF tests
77cccc5 
In b2ce17b, I mistakenly renamed `VectorizedUDFTests` to `ScalarPandasUDF`. This PR fixes the mistake.

Existing tests.

Author: Li Jin <[email protected]>

Closes #20489 from icexelloss/fix-scalar-udf-tests.

(cherry picked from commit caf3044)
Signed-off-by: gatorsmile <[email protected]>
robert3005 pushed a commit to palantir/spark that referenced this pull request Feb 12, 2018
@icexelloss
[MINOR][TEST] Fix class name for Pandas UDF tests
9ebaef0 
## What changes were proposed in this pull request?

In apache@b2ce17b, I mistakenly renamed `VectorizedUDFTests` to `ScalarPandasUDF`. This PR fixes the mistake.

## How was this patch tested?

Existing tests.

Author: Li Jin <[email protected]>

Closes apache#20489 from icexelloss/fix-scalar-udf-tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@icexelloss @SparkQA @HyukjinKwon @gatorsmile