[SPARK-20749][SQL][FOLLOW-UP] Override prettyName for bit_length and octet_length #20358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kiszk @cloud-fan |
HyukjinKwon
approved these changes
Jan 23, 2018
| @@ -141,7 +141,7 @@ statement | |||
| (LIKE? pattern=STRING)? #showTables | |||
| | SHOW TABLE EXTENDED ((FROM | IN) db=identifier)? | |||
| LIKE pattern=STRING partitionSpec? #showTable | |||
| | SHOW DATABASES (LIKE? pattern=STRING)? #showDatabases | |||
| | SHOW DATABASES (LIKE? pattern=STRING)? #showDatabases | |||
|
LGTM |
|
Test build #86510 has finished for PR 20358 at commit
|
|
Merged to master and branch-2.3. |
asfgit
pushed a commit
that referenced
this pull request
Jan 23, 2018
…octet_length ## What changes were proposed in this pull request? We need to override the prettyName for bit_length and octet_length for getting the expected auto-generated alias name. ## How was this patch tested? The existing tests Author: gatorsmile <[email protected]> Closes #20358 from gatorsmile/test2.3More. (cherry picked from commit ee572ba) Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need to override the prettyName for bit_length and octet_length for getting the expected auto-generated alias name.
How was this patch tested?
The existing tests