Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23140][SQL] Add DataSourceV2Strategy to Hive Session state's planner #20305

Closed
wants to merge 3 commits into from
Closed

[SPARK-23140][SQL] Add DataSourceV2Strategy to Hive Session state's planner #20305

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc5d3ce
Add DataSourceV2Strategy to Hive Session state's planner
jerryshao Jan 18, 2018
094b7eb
Fix unit test issues
jerryshao Jan 18, 2018
a978dcc
Further change to adjust the ordering
jerryshao Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,20 +98,7 @@ class HiveSessionStateBuilder(session: SparkSession, parentState: Option[Session
override def extraPlanningStrategies: Seq[Strategy] =
super.extraPlanningStrategies ++ customPlanningStrategies

override def strategies: Seq[Strategy] = {
experimentalMethods.extraStrategies ++
extraPlanningStrategies ++ Seq(
FileSourceStrategy,
DataSourceStrategy(conf),
SpecialLimits,
InMemoryScans,
HiveTableScans,
Scripts,
Aggregation,
JoinSelection,
BasicOperators
)
}
override def strategies: Seq[Strategy] = Seq(HiveTableScans, Scripts) ++ super.strategies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the assumption that experimentalMethods.extraStrategies should always run first.

I think we can just do:

override def extraPlanningStrategies: Seq[Strategy] =
  super.extraPlanningStrategies ++ customPlanningStrategies ++ Seq(HiveTableScans, Scripts)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me update it.

}
}

Expand Down