[SPARK-22993][ML] Clarify HasCheckpointInterval param doc #20188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @srowen @holdenk The MLlib counterparts actually make mention of this, but for some reason the note never got ported over to ML package. The only caveat I can think of is that this doc is the same for all algos that inherit it, but a new algo could potentially not ignore it, but throw an error or manually set the checkpoint dir. For now, ALS, LDA, and GBT all use it and ignore it in the case the checkpoint dir is not set. |
srowen
approved these changes
Jan 8, 2018
holdenk
approved these changes
Jan 8, 2018
|
Test build #85807 has finished for PR 20188 at commit
|
|
Good call @felixcheung! Will update shortly. |
|
Test build #85881 has finished for PR 20188 at commit
|
|
Actually in R setCheckpointDir method is not attached to the SparkContext; I’d leave it as “not set” or “not set in the session”
https://spark.apache.org/docs/latest/api/R/setCheckpointDir.html
|
|
Thanks, latest commit should fix it. |
|
Test build #85886 has finished for PR 20188 at commit
|
felixcheung
approved these changes
Jan 10, 2018
|
merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Jan 10, 2018
## What changes were proposed in this pull request? Add a note to the `HasCheckpointInterval` parameter doc that clarifies that this setting is ignored when no checkpoint directory has been set on the spark context. ## How was this patch tested? No tests necessary, just a doc update. Author: sethah <[email protected]> Closes #20188 from sethah/als_checkpoint_doc. (cherry picked from commit 70bcc9d) Signed-off-by: Felix Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a note to the
HasCheckpointIntervalparameter doc that clarifies that this setting is ignored when no checkpoint directory has been set on the spark context.How was this patch tested?
No tests necessary, just a doc update.