Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22949][ML] Apply CrossValidator approach to Driver/Distributed memory tradeoff for TrainValidationSplit #20143

Closed
wants to merge 1 commit into from
Closed

[SPARK-22949][ML] Apply CrossValidator approach to Driver/Distributed memory tradeoff for TrainValidationSplit #20143

wants to merge 1 commit into from

Conversation

MrBago
Copy link
Contributor

@MrBago MrBago commented Jan 3, 2018

What changes were proposed in this pull request?

Avoid holding all models in memory for TrainValidationSplit.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Jan 4, 2018

Test build #85645 has finished for PR 20143 at commit 6aa46f8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

LGTM
I'm going to merge this with master and branch-2.3, backporting as a fairly important bug fix

Thanks @MrBago !

@asfgit asfgit closed this in cf0aa65 Jan 5, 2018
asfgit pushed a commit that referenced this pull request Jan 5, 2018
@MrBago @jkbradley
[SPARK-22949][ML] Apply CrossValidator approach to Driver/Distributed…
5b524cc 
… memory tradeoff for TrainValidationSplit

## What changes were proposed in this pull request?

Avoid holding all models in memory for `TrainValidationSplit`.

## How was this patch tested?

Existing tests.

Author: Bago Amirbekian <[email protected]>

Closes #20143 from MrBago/trainValidMemoryFix.

(cherry picked from commit cf0aa65)
Signed-off-by: Joseph K. Bradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrBago @SparkQA @jkbradley