Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21893][SPARK-22142][TESTS][FOLLOWUP] Enables PySpark tests for Flume and Kafka in Jenkins #20128

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to enable PySpark tests for Flume and Kafka in Jenkins by explicitly setting the environment variables in modules.py.

Seems we are not taking the dependencies into account when calculating environment variables:

spark/dev/run-tests.py

Lines 554 to 561 in 3a07eff

# setup environment variables
# note - the 'root' module doesn't collect environment variables for all modules. Because the
# environment variables should not be set if a module is not changed, even if running the 'root'
# module. So here we should use changed_modules rather than test_modules.
test_environ = {}
for m in changed_modules:
test_environ.update(m.environ)
setup_test_environ(test_environ)

How was this patch tested?

Manual tests with Jenkins in #20126.

Before - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85559/consoleFull

[info] Setup the following environment variables for tests: 
...

After - https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85560/consoleFull

[info] Setup the following environment variables for tests: 
ENABLE_KAFKA_0_8_TESTS=1
ENABLE_FLUME_TESTS=1
...

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 31, 2017

cc @srowen, @vanzin, @yhuai, @ueshin and @zsxwing who I believe are primarily related with this change.

@HyukjinKwon HyukjinKwon changed the title [SPARK-21893][SPARK-22142][BUILD][FOLLOWUP] Enables PySpark tests for Flume and Kafka in Jenkins [SPARK-21893][SPARK-22142][TESTS][FOLLOWUP] Enables PySpark tests for Flume and Kafka in Jenkins Dec 31, 2017
@srowen
Copy link
Member

srowen commented Dec 31, 2017

Ah I probably missed that when moving these behind a profile. I wasn't fully aware of the dependency mechanism. If it resolves the problem, yes go for it.

@SparkQA
Copy link

SparkQA commented Dec 31, 2017

Test build #85561 has finished for PR 20128 at commit 3b1533a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HyukjinKwon
Copy link
Member Author

Merged to master.

Thank you @srowen, @felixcheung and @ueshin for reviewing this.

@asfgit asfgit closed this in e734a4b Jan 1, 2018
@HyukjinKwon HyukjinKwon deleted the SPARK-21893 branch January 2, 2018 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants