[SPARK-22932] [SQL] Refactor AnalysisContext #20127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85557 has finished for PR 20127 at commit
|
|
retest this please |
|
Test build #85562 has finished for PR 20127 at commit
|
|
retest this please |
|
Test build #85570 has finished for PR 20127 at commit
|
viirya
reviewed
Jan 1, 2018
| } | ||
| } | ||
|
|
||
| private def executeSameContext(plan: LogicalPlan): LogicalPlan = super.execute(plan) |
| @@ -70,6 +71,8 @@ object AnalysisContext { | |||
| } | |||
|
|
|||
| def get: AnalysisContext = value.get() | |||
| def reset(): Unit = value.remove() | |||
There was a problem hiding this comment.
Will be resolved by the future PR.
|
lgtm |
|
Thanks! Merged to master |
|
Hi, @gatorsmile . |
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2018
## What changes were proposed in this pull request? Add a `reset` function to ensure the state in `AnalysisContext ` is per-query. ## How was this patch tested? The existing test cases Author: gatorsmile <[email protected]> Closes #20127 from gatorsmile/refactorAnalysisContext.
|
Yeah, I manually merged it to 2.3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a
resetfunction to ensure the state inAnalysisContextis per-query.How was this patch tested?
The existing test cases