Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST][MINOR] remove redundant EliminateSubqueryAliases in test code #20122

Closed
wants to merge 1 commit into from
Closed

[TEST][MINOR] remove redundant EliminateSubqueryAliases in test code #20122

wants to merge 1 commit into from

Conversation

wzhfy
Copy link
Contributor

@wzhfy wzhfy commented Dec 30, 2017

What changes were proposed in this pull request?

The analyze method in implicit class DslLogicalPlan already includes EliminateSubqueryAliases. So there's no need to call EliminateSubqueryAliases again after calling analyze in some test code.

How was this patch tested?

Existing tests.

@wzhfy wzhfy changed the title [Minor][TEST] remove redundant EliminateSubqueryAliases in test code [TEST][MINOR] remove redundant EliminateSubqueryAliases in test code Dec 30, 2017
@SparkQA
Copy link

SparkQA commented Dec 30, 2017

Test build #85542 has finished for PR 20122 at commit 79daa55.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wzhfy
Copy link
Contributor Author

wzhfy commented Dec 30, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Dec 30, 2017

Test build #85544 has finished for PR 20122 at commit 79daa55.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gatorsmile
gatorsmile reviewed Dec 30, 2017
View reviewed changes
Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@asfgit asfgit closed this in 234d943 Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzhfy @SparkQA @gatorsmile