Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR][BUILD] Fix Java linter errors #20101

Closed
wants to merge 1 commit into from
Closed

[MINOR][BUILD] Fix Java linter errors #20101

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 28, 2017 •
edited
Loading

What changes were proposed in this pull request?

This PR cleans up a few Java linter errors for Apache Spark 2.3 release.

How was this patch tested?

$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks passed.

We can see the result from Travis CI, too.

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @HyukjinKwon .

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 28, 2017

Test build #85464 has finished for PR 20101 at commit 536df66.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jiangxb1987
jiangxb1987 approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Dec 28, 2017

Test build #85470 has finished for PR 20101 at commit 536df66.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 28, 2017

Merged to master

@asfgit asfgit closed this in 5536f31 Dec 28, 2017
@dongjoon-hyun
Copy link
Member Author

Thank you all!

@dongjoon-hyun dongjoon-hyun deleted the fix-java-lint branch December 28, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@jiangxb1987 jiangxb1987 jiangxb1987 approved these changes

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dongjoon-hyun @HyukjinKwon @SparkQA @srowen @jiangxb1987