[SPARK-22916][SQL] shouldn't bias towards build right if user does not specify #20099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85449 has finished for PR 20099 at commit
|
|
Test build #85458 has finished for PR 20099 at commit
|
added 2 commits
December 27, 2017 22:30
|
Test build #85459 has finished for PR 20099 at commit
|
|
retest this please |
|
Test build #85471 has finished for PR 20099 at commit
|
gcz2022
reviewed
Dec 28, 2017
| } | ||
| } | ||
|
|
||
| private def needsBroadcastByHints(joinType: JoinType, left: LogicalPlan, right: LogicalPlan) |
There was a problem hiding this comment.
Maybe using canBroadcastByHints more consistent with the naming convention?
| buildLeft || buildRight | ||
| } | ||
|
|
||
| private def broadcastSideByConfig(joinType: JoinType, left: LogicalPlan, right: LogicalPlan) |
There was a problem hiding this comment.
Is is better to use xxxbySize? byConfig might confuse people.
added 2 commits
December 28, 2017 14:54
|
Test build #85484 has finished for PR 20099 at commit
|
|
Test build #85486 has finished for PR 20099 at commit
|
|
Thanks! Merged to master. |
|
a late LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When there are no broadcast hints, the current spark strategies will prefer to building the right side, without considering the sizes of the two tables. This patch added the logic to consider the sizes of the two tables for the build side. To make the logic clear, the build side is determined by two steps:
broadcastSideByHints;broadcastSideBySizes;How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.