[SPARK-22864][core] Disable allocation schedule in ExecutorAllocationManagerSuite. #20050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ManagerSuite. The scheduled task was racing with the test code and could influence the values returned to the test, triggering assertions. The change adds a new config that is only used during testing, and overrides it on the affected test suite. The issue in the bug can be reliably reproduced by reducing the interval in the test (e.g. to 10ms). While there, fixed an exception that shows up in the logs while these tests run, and simplified some code (which was also causing misleading log messages in the log output of the test).
|
Test build #85286 has finished for PR 20050 at commit
|
felixcheung
approved these changes
Dec 22, 2017
| @@ -1063,6 +1067,9 @@ class ExecutorAllocationManagerSuite | |||
| s"${sustainedSchedulerBacklogTimeout.toString}s") | |||
| .set("spark.dynamicAllocation.executorIdleTimeout", s"${executorIdleTimeout.toString}s") | |||
| .set("spark.dynamicAllocation.testing", "true") | |||
| // SPARK-22864: effectively disable the allocation schedule by setting the period to a | |||
| // really long value. | |||
| .set(TESTING_SCHEDULE_INTERVAL_KEY, "10000") | |||
There was a problem hiding this comment.
this is 10sec? it's not really that long...
There was a problem hiding this comment.
These tests take milliseconds to run, so it's long in context.
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduled task was racing with the test code and could influence
the values returned to the test, triggering assertions. The change adds
a new config that is only used during testing, and overrides it
on the affected test suite.
The issue in the bug can be reliably reproduced by reducing the interval
in the test (e.g. to 10ms).
While there, fixed an exception that shows up in the logs while these
tests run, and simplified some code (which was also causing misleading
log messages in the log output of the test).