[SPARK-22855][BUILD] Add -no-java-comments to sbt docs/scalacOptions #20042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on scala 2.12 Prevents Scala 2.12 scaladoc from blowing up attempting to parse java comments. Also moves scaladoc configs out of the TestSettings and into the standard sharedSettings section in SparkBuild.scala.
srowen
approved these changes
Dec 21, 2017
|
Test build #4021 has finished for PR 20042 at commit
|
|
retest this please |
|
Test build #85256 has finished for PR 20042 at commit
|
|
Merged to master |
|
Thanks @srowen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents Scala 2.12 scaladoc from blowing up attempting to parse java comments.
What changes were proposed in this pull request?
Adds -no-java-comments to docs/scalacOptions under Scala 2.12. Also
moves scaladoc configs out of the TestSettings and into the standard sharedSettings
section in SparkBuild.scala.
How was this patch tested?
SBT_OPTS=-Dscala-2.12 sbt
++2.12.4
tags/publishLocal