[SPARK-21168] KafkaRDD should always set kafka clientId. #19887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Test build #4153 has finished for PR 19887 at commit
|
|
Seems reasonable; maybe @koeninger has a thought |
|
Jenkins, retest this please |
|
Seems ok to me, long as it passes retest |
|
Test build #89733 has finished for PR 19887 at commit
|
|
Merging to master, thanks @liu-zhaokun |
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Dec 6, 2018
https://issues.apache.org/jira/browse/SPARK-21168 There are no a number of other places that a client ID should be set,and I think we should use consumer.clientId in the clientId method,because the fetch request will be used by the same consumer behind.
zzcclp
added a commit
to zzcclp/spark
that referenced
this pull request
Sep 20, 2019
…19887 https://issues.apache.org/jira/browse/SPARK-21168 There are no a number of other places that a client ID should be set,and I think we should use consumer.clientId in the clientId method,because the fetch request will be used by the same consumer behind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-21168
There are no a number of other places that a client ID should be set,and I think we should use consumer.clientId in the clientId method,because the fetch request will be used by the same consumer behind.