[SPARK-22067][SQL] ArrowWriter should use position when setting UTF8String ByteBuffer #19284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ueshin and @icexelloss this came up while testing with Arrow 0.7.0. It seems that when Spark gets row data as a UTF8String ByteBuffer, the data can start at an offset which becomes the ByteBuffer position when this line is called https://github.com/apache/spark/blob/master/common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java#L171 |
|
LGTM. What's the Arrow bug you mentioned? |
|
Ooops, I referenced the wrong JIRA, it was ARROW-1443 PR: apache/arrow#1022 ArrowBuf.setBytes was not using the destination buffer properly |
|
Test build #81952 has finished for PR 19284 at commit
|
|
LGTM. |
|
Thanks! merging to master. |
|
Thanks @ueshin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The ArrowWriter StringWriter was setting Arrow data using a position of 0 instead of the actual position in the ByteBuffer. This was currently working because of a bug ARROW-1443, and has been fixed as of
Arrow 0.7.0. Testing with this version revealed the error in ArrowConvertersSuite test string conversion.
How was this patch tested?
Existing tests, manually verified working with Arrow 0.7.0