-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-21210][DOC][ML] Javadoc 8 fixes for ML shared param traits #18420
Conversation
Just as a little side note, actually, while fixing some javadoc at that time, I realised that even LGTM. |
Test build #78637 has finished for PR 18420 at commit
|
@HyukjinKwon true it is private. But there is the possibility that (at least some of) these shared params are made public in the future. So worth doing I guess. |
Jenkins retest this please |
Test build #78684 has finished for PR 18420 at commit
|
Will wait for pip tests to get sorted out before trying again! |
Sad ... I guess it fails only on some environments in Jenkins BTW. |
Test build #3817 has finished for PR 18420 at commit
|
Jenkins retest this please |
Test build #78885 has finished for PR 18420 at commit
|
Merged to master/2.2 |
PR #15999 included fixes for doc strings in the ML shared param traits (occurrences of `>` and `>=`). This PR simply uses the HTML-escaped version of the param doc to embed into the Scaladoc, to ensure that when `SharedParamsCodeGen` is run, the generated javadoc will be compliant for Java 8. ## How was this patch tested? Existing tests Author: Nick Pentreath <[email protected]> Closes #18420 from MLnick/shared-params-javadoc8. (cherry picked from commit 70085e8) Signed-off-by: Sean Owen <[email protected]>
PR apache#15999 included fixes for doc strings in the ML shared param traits (occurrences of `>` and `>=`). This PR simply uses the HTML-escaped version of the param doc to embed into the Scaladoc, to ensure that when `SharedParamsCodeGen` is run, the generated javadoc will be compliant for Java 8. ## How was this patch tested? Existing tests Author: Nick Pentreath <[email protected]> Closes apache#18420 from MLnick/shared-params-javadoc8.
PR #15999 included fixes for doc strings in the ML shared param traits (occurrences of
>
and>=
).This PR simply uses the HTML-escaped version of the param doc to embed into the Scaladoc, to ensure that when
SharedParamsCodeGen
is run, the generated javadoc will be compliant for Java 8.How was this patch tested?
Existing tests