Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21168][DStreams] Set kafka clientId while fetch messages #18383

Closed
wants to merge 1 commit into from

Conversation

dixingxing0
Copy link

What changes were proposed in this pull request?

Change KafkaRDD to set kafka clientId while fetch messages, as in our case ,we use clientId at kafka server side.

How was this patch tested?

All tests still passed.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Jun 22, 2017

@dijingran would there be a number of other places that a client ID should be set? I want to make sure it's consistent

@zsxwing
Copy link
Member

zsxwing commented Jun 22, 2017

@dijingran could you fix the JIRA number in the PR title? Also please change [SS] to [DSTREAMS].

@HyukjinKwon
Copy link
Member

gentle ping @dijingran. I want to be sure if it is in progress in any way.

@asfgit asfgit closed this in 3a45c7f Aug 5, 2017
@dixingxing0 dixingxing0 changed the title [SPARK-21167][SS] Set kafka clientId while fetch messages [SPARK-21168][SS] Set kafka clientId while fetch messages Nov 22, 2017
@dixingxing0 dixingxing0 changed the title [SPARK-21168][SS] Set kafka clientId while fetch messages [SPARK-21168][DStreams] Set kafka clientId while fetch messages Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants