[SPARK-21092][SQL] Wire SQLConf in logical plan and expressions #18299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
changed the title
|
cc @wzhfy for review / CBO cc @sameeragarwal this is what we discussed. |
|
Test build #78036 has finished for PR 18299 at commit
|
|
Test build #78038 has finished for PR 18299 at commit
|
|
Since we have a thread local variable in |
|
The issue is that SparkSession might change the way they are wired and it's not always the case that when we create a new thread, we set the thread local conf. |
| .union(constructIsNotNullConstraints(validConstraints)) | ||
| .filter { c => | ||
| c.references.nonEmpty && c.references.subsetOf(outputSet) && c.deterministic | ||
| } |
There was a problem hiding this comment.
should we also bound their size as you suggested?
There was a problem hiding this comment.
That belongs in a separate patch.
|
Got it, thanks. |
wzhfy
reviewed
Jun 14, 2017
| assert(aliasedRelation.analyze.constraints.nonEmpty) | ||
|
|
||
| SQLConf.get.setConf(SQLConf.CONSTRAINT_PROPAGATION_ENABLED, false) | ||
| assert(aliasedRelation.analyze.constraints.isEmpty) |
|
LGTM except one minor comment. |
|
Test build #78068 has finished for PR 18299 at commit
|
|
Test build #78070 has finished for PR 18299 at commit
|
|
Test build #78071 has finished for PR 18299 at commit
|
|
Test build #78077 has finished for PR 18299 at commit
|
|
Merging in master. |
cloud-fan
reviewed
Jun 16, 2017
| @@ -87,6 +87,11 @@ class SparkSession private( | |||
|
|
|||
| sparkContext.assertNotStopped() | |||
|
|
|||
| // If there is no active SparkSession, uses the default SQL conf. Otherwise, use the session's. | |||
| SQLConf.setSQLConfGetter(() => { | |||
| SparkSession.getActiveSession.map(_.sessionState.conf).getOrElse(SQLConf.getFallbackConf) | |||
There was a problem hiding this comment.
shall we move this to SparkSession.Builder.getOrCreate?
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
## What changes were proposed in this pull request? It is really painful to not have configs in logical plan and expressions. We had to add all sorts of hacks (e.g. pass SQLConf explicitly in functions). This patch exposes SQLConf in logical plan, using a thread local variable and a getter closure that's set once there is an active SparkSession. The implementation is a bit of a hack, since we didn't anticipate this need in the beginning (config was only exposed in physical plan). The implementation is described in `SQLConf.get`. In terms of future work, we should follow up to clean up CBO (remove the need for passing in config). ## How was this patch tested? Updated relevant tests for constraint propagation. Author: Reynold Xin <[email protected]> Closes apache#18299 from rxin/SPARK-21092.
wangyum
pushed a commit
to 1haodian/spark
that referenced
this pull request
Jun 23, 2017
… conf in LogicalPlan ## What changes were proposed in this pull request? After wiring `SQLConf` in logical plan ([PR 18299](apache#18299)), we can remove the need of passing `conf` into `def stats` and `def computeStats`. ## How was this patch tested? Covered by existing tests, plus some modified existing tests. Author: wangzhenhua <[email protected]> Author: Zhenhua Wang <[email protected]> Closes apache#18391 from wzhfy/removeConf.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
… conf in LogicalPlan ## What changes were proposed in this pull request? After wiring `SQLConf` in logical plan ([PR 18299](apache#18299)), we can remove the need of passing `conf` into `def stats` and `def computeStats`. ## How was this patch tested? Covered by existing tests, plus some modified existing tests. Author: wangzhenhua <[email protected]> Author: Zhenhua Wang <[email protected]> Closes apache#18391 from wzhfy/removeConf.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
It is really painful to not have configs in logical plan and expressions. We had to add all sorts of hacks (e.g. pass SQLConf explicitly in functions). This patch exposes SQLConf in logical plan, using a thread local variable and a getter closure that's set once there is an active SparkSession. The implementation is a bit of a hack, since we didn't anticipate this need in the beginning (config was only exposed in physical plan). The implementation is described in `SQLConf.get`. In terms of future work, we should follow up to clean up CBO (remove the need for passing in config). Updated relevant tests for constraint propagation. Author: Reynold Xin <[email protected]> Closes apache#18299 from rxin/SPARK-21092.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It is really painful to not have configs in logical plan and expressions. We had to add all sorts of hacks (e.g. pass SQLConf explicitly in functions). This patch exposes SQLConf in logical plan, using a thread local variable and a getter closure that's set once there is an active SparkSession.
The implementation is a bit of a hack, since we didn't anticipate this need in the beginning (config was only exposed in physical plan). The implementation is described in
SQLConf.get.In terms of future work, we should follow up to clean up CBO (remove the need for passing in config).
How was this patch tested?
Updated relevant tests for constraint propagation.