Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20781] the location of Dockerfile in docker.properties.templat is wrong #18013

Closed
wants to merge 1 commit into from
Closed

[SPARK-20781] the location of Dockerfile in docker.properties.templat is wrong #18013

wants to merge 1 commit into from

Conversation

liu-zhaokun
Copy link
Contributor

https://issues.apache.org/jira/browse/SPARK-20781
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"

@SparkQA
Copy link

SparkQA commented May 17, 2017

Test build #3717 has started for PR 18013 at commit a0830c1.

@liu-zhaokun
Copy link
Contributor Author

@srowen
Hi,could you help me merge this PR?

@srowen
Copy link
Member

srowen commented May 17, 2017

Same, tests haven't passed. You do not want to ping nearly this often

@SparkQA
Copy link

SparkQA commented May 19, 2017

Test build #3724 has started for PR 18013 at commit a0830c1.

@SparkQA
Copy link

SparkQA commented May 19, 2017

Test build #3735 has finished for PR 18013 at commit a0830c1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 19, 2017

Test build #3738 has finished for PR 18013 at commit a0830c1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

+1, LGTM, too.

asfgit pushed a commit that referenced this pull request May 19, 2017
@liu-zhaokun @srowen
[SPARK-20781] the location of Dockerfile in docker.properties.templat…
e9804b3 
… is wrong

[https://issues.apache.org/jira/browse/SPARK-20781](https://issues.apache.org/jira/browse/SPARK-20781)
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"

Author: liuzhaokun <[email protected]>

Closes #18013 from liu-zhaokun/dockerfile_location.

(cherry picked from commit 749418d)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in 749418d May 19, 2017
asfgit pushed a commit that referenced this pull request May 19, 2017
@liu-zhaokun @srowen
[SPARK-20781] the location of Dockerfile in docker.properties.templat…
3aad598 
… is wrong

[https://issues.apache.org/jira/browse/SPARK-20781](https://issues.apache.org/jira/browse/SPARK-20781)
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"

Author: liuzhaokun <[email protected]>

Closes #18013 from liu-zhaokun/dockerfile_location.

(cherry picked from commit 749418d)
Signed-off-by: Sean Owen <[email protected]>
liyichao pushed a commit to liyichao/spark that referenced this pull request May 24, 2017
@liu-zhaokun @liyichao
[SPARK-20781] the location of Dockerfile in docker.properties.templat…
4ae1608 
… is wrong

[https://issues.apache.org/jira/browse/SPARK-20781](https://issues.apache.org/jira/browse/SPARK-20781)
the location of Dockerfile in docker.properties.template should be "../external/docker/spark-mesos/Dockerfile"

Author: liuzhaokun <[email protected]>

Closes apache#18013 from liu-zhaokun/dockerfile_location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liu-zhaokun @SparkQA @srowen @dongjoon-hyun