[SPARK-20718][SQL][followup] Fix canonicalization for HiveTableScanExec #17962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
May 12, 2017
| @@ -442,4 +442,14 @@ object QueryPlan { | |||
| } | |||
| }.canonicalized.asInstanceOf[T] | |||
| } | |||
|
|
|||
| /** Normalize and reorder the expressions in the given sequence. */ | |||
| def canonicalizeExprSeq(exprSeq: Seq[Expression], output: AttributeSeq): Seq[Expression] = { | |||
There was a problem hiding this comment.
nit: normalizePredicates
gatorsmile
reviewed
May 12, 2017
| /** Normalize and reorder the expressions in the given sequence. */ | ||
| def canonicalizeExprSeq(exprSeq: Seq[Expression], output: AttributeSeq): Seq[Expression] = { | ||
| if (exprSeq.nonEmpty) { | ||
| val normalizedExprs = QueryPlan.normalizeExprId(exprSeq.reduce(And), output) |
There was a problem hiding this comment.
nit: QueryPlan.normalizeExprId -> normalizeExprId
gatorsmile
reviewed
May 12, 2017
| @@ -442,4 +442,14 @@ object QueryPlan { | |||
| } | |||
| }.canonicalized.asInstanceOf[T] | |||
| } | |||
|
|
|||
| /** Normalize and reorder the expressions in the given sequence. */ | |||
There was a problem hiding this comment.
Where do we reorder the predicates?
There was a problem hiding this comment.
It links predicates with AND and pass it to def normalizeExprId, in which Canonicalize.execute is called. That's where we do the reordering.
There was a problem hiding this comment.
Got it. Could you update the above comment, since this is a little bit confusing.
There was a problem hiding this comment.
OK. I'll update the comments.
|
LGTM cc @cloud-fan |
|
LGTM |
|
Test build #76853 has finished for PR 17962 at commit
|
|
Test build #76859 has finished for PR 17962 at commit
|
|
Test build #76861 has finished for PR 17962 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 12, 2017
## What changes were proposed in this pull request? Fix canonicalization for different filter orders in `HiveTableScanExec`. ## How was this patch tested? Added a new test case. Author: wangzhenhua <[email protected]> Closes #17962 from wzhfy/canonicalizeHiveTableScanExec. (cherry picked from commit 54b4f2a) Signed-off-by: Wenchen Fan <[email protected]>
|
thanks, merging to master/2.2! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
May 19, 2017
## What changes were proposed in this pull request? Fix canonicalization for different filter orders in `HiveTableScanExec`. ## How was this patch tested? Added a new test case. Author: wangzhenhua <[email protected]> Closes apache#17962 from wzhfy/canonicalizeHiveTableScanExec.
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? Fix canonicalization for different filter orders in `HiveTableScanExec`. ## How was this patch tested? Added a new test case. Author: wangzhenhua <[email protected]> Closes apache#17962 from wzhfy/canonicalizeHiveTableScanExec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix canonicalization for different filter orders in
HiveTableScanExec.How was this patch tested?
Added a new test case.