Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20410][SQL] Make sparkConf a def in SharedSQLContext #17705

Closed
wants to merge 3 commits into from
Closed

[SPARK-20410][SQL] Make sparkConf a def in SharedSQLContext #17705

wants to merge 3 commits into from

Conversation

hvanhovell
Copy link
Contributor

@hvanhovell hvanhovell commented Apr 20, 2017 •
edited
Loading

What changes were proposed in this pull request?

It is kind of annoying that SharedSQLContext.sparkConf is a val when overriding test cases, because you cannot call super on it. This PR makes it a function.

How was this patch tested?

Existing tests.

@hvanhovell hvanhovell changed the title [SPARK-20410][SQL] Make spark conf a val in SharedSQLContext [SPARK-20410][SQL] Make sparkConf a def in SharedSQLContext Apr 20, 2017
@SparkQA
Copy link

SparkQA commented Apr 20, 2017

Test build #75987 has finished for PR 17705 at commit 638ac34.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 20, 2017

Test build #75989 has finished for PR 17705 at commit e2401f9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 20, 2017

Test build #75993 has finished for PR 17705 at commit f4cb5cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SingleLevelAggregateHashMapSuite extends DataFrameAggregateSuite with BeforeAndAfter

@rxin
Copy link
Contributor

rxin commented Apr 20, 2017

LGTM

@hvanhovell
Copy link
Contributor Author

I am merging this.

asfgit pushed a commit that referenced this pull request Apr 20, 2017
@hvanhovell
[SPARK-20410][SQL] Make sparkConf a def in SharedSQLContext
01f6262 
## What changes were proposed in this pull request?
It is kind of annoying that `SharedSQLContext.sparkConf` is a val when overriding test cases, because you cannot call `super` on it. This PR makes it a function.

## How was this patch tested?
Existing tests.

Author: Herman van Hovell <[email protected]>

Closes #17705 from hvanhovell/SPARK-20410.

(cherry picked from commit 0332063)
Signed-off-by: Herman van Hovell <[email protected]>
@asfgit asfgit closed this in 0332063 Apr 20, 2017
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
@hvanhovell
[SPARK-20410][SQL] Make sparkConf a def in SharedSQLContext
dd3a061 
## What changes were proposed in this pull request?
It is kind of annoying that `SharedSQLContext.sparkConf` is a val when overriding test cases, because you cannot call `super` on it. This PR makes it a function.

## How was this patch tested?
Existing tests.

Author: Herman van Hovell <[email protected]>

Closes apache#17705 from hvanhovell/SPARK-20410.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvanhovell @SparkQA @rxin