[SPARK-20232][Python] Improve combineByKey docs #17545
Closed
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add note on memory allocation * Change example code to use different mergeValue and mergeCombiners
|
Test build #3643 has finished for PR 17545 at commit
|
|
So the associated JIRA says "Doesn't include note about memory allocation (on aggregateBykey)" - what did you want to add in |
|
The note meant that |
|
Ok sounds good, I just wanted to make sure since the JIRA had it in two separate bullet points and I wasn't sure if it was a second thing you wanted to talk about. LGTM. |
|
Merged to master, thanks for working on this @dgingrich |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request? Improve combineByKey documentation: * Add note on memory allocation * Change example code to use different mergeValue and mergeCombiners ## How was this patch tested? Doctest. ## Legal This is my original work and I license the work to the project under the project’s open source license. Author: David Gingrich <[email protected]> Closes apache#17545 from dgingrich/topic-spark-20232-combinebykey-docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve combineByKey documentation:
How was this patch tested?
Doctest.
Legal
This is my original work and I license the work to the project under the project’s open source license.