[SPARK-20231] [SQL] Refactor star schema code for the subsequent star join detection in CBO #17544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gatorsmile I did a small refactoring for star schema. Would you please review. Thank you. |
|
add to whitelist |
|
ok to test |
gatorsmile
reviewed
Apr 5, 2017
| */ | ||
| def findStarJoins( | ||
| input: Seq[LogicalPlan], | ||
| conditions: Seq[Expression]): Seq[LogicalPlan] = { |
There was a problem hiding this comment.
To the other reviewers, this is to address the comment by @cloud-fan in the previous PR.
#15363 (comment)
gatorsmile
reviewed
Apr 5, 2017
| // dimension table is a FK-PK join. Heuristically, a selective dimension may reduce | ||
| // the result of a join. | ||
| // Also, conservatively assume that a fact table is joined with more than one dimension. | ||
| if (dimTables.size >= 2 && isSelectiveStarJoin(dimTables, conditions)) { |
There was a problem hiding this comment.
dimTables.size >= 2 is removed in the new code? Could you please explain it?
There was a problem hiding this comment.
@gatorsmile I moved the condition from reorderStarJoin to findStarJoin to be used by both ReorderJoin and CostBasedReorder.
|
Test build #75557 has finished for PR 17544 at commit
|
gatorsmile
reviewed
Apr 6, 2017
| } | ||
| } | ||
|
|
||
| if (eligibleDimPlans.isEmpty || eligibleDimPlans.size < 2) { |
|
LGTM. Look forward to your next PR for merging start join detection with CBO. |
|
Thanks! Merging to master. |
|
@gatorsmile Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This commit moves star schema code from
join.scalatoStarSchemaDetection.scala. It also applies some minor fixes inStarJoinReorderSuite.scala.How was this patch tested?
Run existing
StarJoinReorderSuite.scala.