[SPARK-20195][SPARKR][SQL] add createTable catalog API and deprecate createExternalTable #17511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without return values
|
Test build #75465 has finished for PR 17511 at commit
|
|
Test build #75467 has finished for PR 17511 at commit
|
|
Test build #75512 has finished for PR 17511 at commit
|
gatorsmile
reviewed
Apr 5, 2017
| @@ -557,7 +557,7 @@ setMethod("insertInto", | |||
| jmode <- convertToJSaveMode(ifelse(overwrite, "overwrite", "append")) | |||
| write <- callJMethod(x@sdf, "write") | |||
| write <- callJMethod(write, "mode", jmode) | |||
| callJMethod(write, "insertInto", tableName) | |||
| invisible(callJMethod(write, "insertInto", tableName)) | |||
There was a problem hiding this comment.
Just wondering what is the reason why we add invisible in this PR? Is it related to this deprecation?
There was a problem hiding this comment.
It's a R usability thing: for method not returning any value (in these cases the Scala method is defined as foo : Unit), it will print NULL.
so we say invisible to get it to not print out the value, that's all
so no, it's not really related to this deprecation - it's probably been around for quite a while
|
merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following up on #17483, add createTable (which is new in 2.2.0) and deprecate createExternalTable, plus a number of minor fixes
How was this patch tested?
manual, unit tests