[SPARK-20173][SQL][hive-thriftserver] Throw NullPointerException when HiveThriftServer2 is shutdown #17496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Mar 31, 2017
| @@ -82,7 +82,9 @@ object HiveThriftServer2 extends Logging { | |||
|
|
|||
| ShutdownHookManager.addShutdownHook { () => | |||
| SparkSQLEnv.stop() | |||
| uiTab.foreach(_.detach()) | |||
| if (uiTab != null) { | |||
| uiTab.foreach(_.detach()) | |||
There was a problem hiding this comment.
I think it's easier to just init the Option to None instead of _ which is null.
There was a problem hiding this comment.
Yes of course.
OK, i'll change it as you suggested. Thanks a lot.
srowen
approved these changes
Apr 1, 2017
|
Test build #3630 has finished for PR 17496 at commit
|
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the shutdown hook called before the variable
uiTabis set , it will throw a NullPointerException.How was this patch tested?
manual tests