[SPARK-20143][SQL] DataType.fromJson should throw an exception with better message #17468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(BTW, I believe this does not make a conflict with PR 17406) |
|
Test build #75357 has finished for PR 17468 at commit
|
|
@gatorsmile, could you take a look please? |
gatorsmile
reviewed
Mar 30, 2017
| case other => nonDecimalNameToType.getOrElse(other, { | ||
| throw new IllegalArgumentException( | ||
| s"Failed to convert the JSON string '$name' to a data type.") | ||
| }) |
gatorsmile
reviewed
Mar 30, 2017
| @@ -164,6 +167,10 @@ object DataType { | |||
| ("sqlType", v: JValue), | |||
| ("type", JString("udt"))) => | |||
| new PythonUserDefinedType(parseDataType(v), pyClass, serialized) | |||
|
|
|||
| case other: JValue => | |||
gatorsmile
reviewed
Mar 30, 2017
| @@ -179,6 +186,9 @@ object DataType { | |||
| ("nullable", JBool(nullable)), | |||
| ("type", dataType: JValue)) => | |||
| StructField(name, parseDataType(dataType), nullable) | |||
| case other: JValue => | |||
There was a problem hiding this comment.
or case _ =>. Then, you can directly use json in the following message.
|
LGTM except a few minor comments. |
|
Thank you @gatorsmile. |
|
Test build #75405 has finished for PR 17468 at commit
|
|
@gatorsmile, could this get merged maybe? |
|
retest this please |
|
Test build #75456 has finished for PR 17468 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently,
DataType.fromJsonthrowsscala.MatchErrororjava.util.NoSuchElementExceptionin some cases when the JSON input is invalid as below:After this PR,
How was this patch tested?
Unit test added in
DataTypeSuite.