Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS][MINOR] Fixed a few typos in the Structured Streaming documentation #17443

Closed
wants to merge 2 commits into from
Closed

[DOCS][MINOR] Fixed a few typos in the Structured Streaming documentation #17443

wants to merge 2 commits into from

Conversation

aseigneurin
Copy link
Contributor

Fixed a few typos.

There is one more I'm not sure of:

        Append mode uses watermark to drop old aggregation state. But the output of a 
        windowed aggregation is delayed the late threshold specified in `withWatermark()` as by
        the modes semantics, rows can be added to the Result Table only once after they are

Not sure how to change is delayed the late threshold.

srowen
srowen requested changes Mar 27, 2017
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple should be reverted but the rest are OK

docs/structured-streaming-programming-guide.md Outdated
@@ -713,15 +713,15 @@ old windows correctly, as illustrated below.

![Handling Late Data](img/structured-streaming-late-data.png)

However, to run this query for days, it's necessary for the system to bound the amount of
However, to run this query for days, it is necessary for the system to bound the amount of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a typo

docs/structured-streaming-programming-guide.md Outdated
@@ -930,7 +930,7 @@ There are a few types of output modes.
new rows added to the Result Table since the last trigger will be
outputted to the sink. This is supported for only those queries where
rows added to the Result Table is never going to change. Hence, this mode
guarantees that each row will be output only once (assuming
guarantees that each row will be outputted only once (assuming
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a typo, I agree, but I thought it made sense to keep the same formulation as what is used in the same paragraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, hm. As a native speaker, I would have said "outputted" is incorrect actually. But it looks like it's an accepted alternative. Well, whatever's the smaller change to achieve consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I also thought "outputted" was strange.

I have reverted my change anyway.

@srowen
Copy link
Member

srowen commented Mar 27, 2017

@tdas what did you intend in the paragraph cited in the description? I'm also not sure.

@srowen
Copy link
Member

srowen commented Mar 30, 2017

@aseigneurin Please read http://spark.apache.org/contributing.html too. As you might imagine "typos" isn't useful as a title. Write "[MINOR]" too

@aseigneurin aseigneurin changed the title typos [DOCS][MINOR] Fixed a few typos in the Structured Streaming documentation Mar 30, 2017
@aseigneurin
Copy link
Contributor Author

@srowen does this mean I should open a JIRA for this?

@SparkQA
Copy link

SparkQA commented Mar 30, 2017

Test build #3620 has finished for PR 17443 at commit a2faf88.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Mar 30, 2017

Merged to master

@asfgit asfgit closed this in 669a11b Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aseigneurin @srowen @SparkQA