[SPARK-20097][ML] Fix visibility discrepancy with numInstances and degreesOfFreedom in LR and GLR #17431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkbradley this is what we discussed in #12823 Also I noticed that a lot of variables in LinearRegression are missing the |
|
Test build #75214 has finished for PR 17431 at commit
|
BenFradet
changed the title
|
LGTM We could fix up the annotations for LinearRegression - do you want to open a new JIRA/PR for that? |
|
Merged to master. Thanks! |
|
Yup, I'm on it, thanks @MLnick ! |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…greesOfFreedom in LR and GLR ## What changes were proposed in this pull request? - made `numInstances` public in GLR - made `degreesOfFreedom` public in LR ## How was this patch tested? reran the concerned test suites Author: Benjamin Fradet <[email protected]> Closes apache#17431 from BenFradet/SPARK-20097.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
numInstancespublic in GLRdegreesOfFreedompublic in LRHow was this patch tested?
reran the concerned test suites