Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BackPort-2.1][SPARK-19319][SparkR]:SparkR Kmeans summary returns error when the cluster size doesn't equal to k #16761

Closed
wants to merge 2 commits into from

Conversation

wangmiao1981
Copy link
Contributor

What changes were proposed in this pull request?

Backport fix of #16666

How was this patch tested?

Backport unit tests

@SparkQA
Copy link

SparkQA commented Feb 1, 2017

Test build #72233 has finished for PR 16761 at commit 5eb2835.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 1, 2017

Test build #72262 has finished for PR 16761 at commit 3489899.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

hmm, I wasn't sure to have the parameter changes in 2.1, what do you think?

@wangmiao1981
Copy link
Contributor Author

If we don't want to change the parameters in 2.1, it is not necessary to port it back. It is because the bug occurs only if you use random mode with specific seed. If we don't provide seed, with default seed, it should be fine. In the future, if there is a case with default seed has problem, we can fix it again.

Thanks!

@felixcheung
Copy link
Member

merged to 2.1. Thanks @wangmiao1981 please close this PR.

asfgit pushed a commit that referenced this pull request Feb 12, 2017
…or when the cluster size doesn't equal to k

## What changes were proposed in this pull request?

Backport fix of #16666

## How was this patch tested?

Backport unit tests

Author: [email protected] <[email protected]>

Closes #16761 from wangmiao1981/kmeansport.
@felixcheung
Copy link
Member

ping @wangmiao1981 please close this PR - backport PR merged to non-master branch isn't closed automatically.

@wangmiao1981
Copy link
Contributor Author

Thanks! I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants