[SPARK-19043][SQL]Make SparkSQLSessionManager more configurable #16445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager property only.
|
Can one of the admins verify this patch? |
gatorsmile
reviewed
May 23, 2017
| @@ -34,28 +30,13 @@ import org.apache.spark.sql.hive.thriftserver.server.SparkSQLOperationManager | |||
|
|
|||
|
|
|||
| private[hive] class SparkSQLSessionManager(hiveServer: HiveServer2, sqlContext: SQLContext) | |||
| extends SessionManager(hiveServer) | |||
| with ReflectedCompositeService { | |||
There was a problem hiding this comment.
What is the reason this PR removes ReflectedCompositeService?
gatorsmile
reviewed
May 23, 2017
| setSuperField(this, "operationManager", sparkSqlOperationManager) | ||
| addService(sparkSqlOperationManager) | ||
|
|
||
| initCompositeService(hiveConf) |
gatorsmile
reviewed
May 23, 2017
| setSuperField(this, "operationManager", sparkSqlOperationManager) | ||
| addService(sparkSqlOperationManager) |
There was a problem hiding this comment.
This line is also needed, right?
|
Hi @yaooqinn, is this PR active? if so, would you address or answer to the review comments above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To make SparkSQLSessionManager's background operation thread pool not only configurable for pool size but also the wait queue size and the thread keep alive time. To be consistent with HiveServer2's behavior.
How was this patch tested?
manual tests