[SPARK-18702][SQL] input_file_block_start and input_file_block_length #16133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ueshin |
| val inputMetrics = context.taskMetrics().inputMetrics | ||
| val existingBytesRead = inputMetrics.bytesRead | ||
| private val inputMetrics = context.taskMetrics().inputMetrics | ||
| private val existingBytesRead = inputMetrics.bytesRead | ||
|
|
||
| // Sets the thread local variable for the file's name |
There was a problem hiding this comment.
nit. Updating comment together?
There was a problem hiding this comment.
I agree with it and also the same comment in HadoopRDD.
|
Test build #69632 has finished for PR 16133 at commit
|
ueshin
reviewed
Dec 4, 2016
| checkAnswer(data.select(input_file_name()).limit(1), Row("")) | ||
| // Test the 3 expressions when reading from files | ||
| val q = spark.read.parquet(dir.getCanonicalPath).select( | ||
| input_file_name(), expr("input_file_block_start()"), expr("input_file_block_length()")) |
There was a problem hiding this comment.
We should add input_file_block_start(), input_file_block_length() to functions.scala and use them the same as input_file_name()?
There was a problem hiding this comment.
I'm actually intentionally not adding those because I don't know how common these expressions will be.
| checkAnswer(data.select(input_file_name()).limit(1), Row("")) | ||
| // Test the 3 expressions when reading from files | ||
| val q = df.select( | ||
| input_file_name(), expr("input_file_block_start()"), expr("input_file_block_length()")) |
| checkAnswer(data.select(input_file_name()).limit(1), Row("")) | ||
| // Test the 3 expressions when reading from files | ||
| val q = df.select( | ||
| input_file_name(), expr("input_file_block_start()"), expr("input_file_block_length()")) |
|
Test build #69642 has finished for PR 16133 at commit
|
viirya
reviewed
Dec 5, 2016
| } | ||
|
|
||
| /** | ||
| * The thread variable for the name of the current file being read. This is used by |
There was a problem hiding this comment.
nit: this comment can be updated too.
|
Thanks - going to merge this in master. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 15, 2016
## What changes were proposed in this pull request? We currently have function input_file_name to get the path of the input file, but don't have functions to get the block start offset and length. This patch introduces two functions: 1. input_file_block_start: returns the file block start offset, or -1 if not available. 2. input_file_block_length: returns the file block length, or -1 if not available. ## How was this patch tested? Updated existing test cases in ColumnExpressionSuite that covered input_file_name to also cover the two new functions. Author: Reynold Xin <[email protected]> Closes apache#16133 from rxin/SPARK-18702.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? We currently have function input_file_name to get the path of the input file, but don't have functions to get the block start offset and length. This patch introduces two functions: 1. input_file_block_start: returns the file block start offset, or -1 if not available. 2. input_file_block_length: returns the file block length, or -1 if not available. ## How was this patch tested? Updated existing test cases in ColumnExpressionSuite that covered input_file_name to also cover the two new functions. Author: Reynold Xin <[email protected]> Closes apache#16133 from rxin/SPARK-18702.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We currently have function input_file_name to get the path of the input file, but don't have functions to get the block start offset and length. This patch introduces two functions:
input_file_block_start: returns the file block start offset, or -1 if not available.
input_file_block_length: returns the file block length, or -1 if not available.
How was this patch tested?
Updated existing test cases in ColumnExpressionSuite that covered input_file_name to also cover the two new functions.