[SPARK-15915][SQL] Logical plans should use subqueries eliminated plan when override sameResult. #13668
Conversation
…not using subqueries eliminated plan to compare can cacheTable.
|
LGTM |
|
Test build #60503 has finished for PR 13668 at commit
|
|
Jenkins, retest this please. |
|
Test build #60505 has finished for PR 13668 at commit
|
|
Jenkins, retest this please. |
|
Test build #60539 has finished for PR 13668 at commit
|
| otherOutput.map(_.dataType) == output.map(_.dataType) && otherData == data | ||
| case _ => false | ||
| override def sameResult(plan: LogicalPlan): Boolean = { | ||
| EliminateSubQueries(plan) match { |
There was a problem hiding this comment.
Maybe we should execute EliminateSubQueries when looking up cache entry? 1.6 is not like 2.0, we don't have the canonized method and can't memorize the result of EliminateSubQueries.
There was a problem hiding this comment.
I'm sorry but I couldn't find the reason.
Is the purpose to execute EliminateSubQueries to memorize the result of it?
…n when override sameResult. ## What changes were proposed in this pull request? This pr is a backport of #13638 for `branch-1.6`. ## How was this patch tested? Added the same test as #13638 modified for `branch-1.6`. Author: Takuya UESHIN <[email protected]> Closes #13668 from ueshin/issues/SPARK-15915_1.6.
|
thanks, merging to 1.6! @ueshin can you close this PR? it won't be closed automatically. |
|
@cloud-fan Sure, thank you for merging this! |
…n when override sameResult. ## What changes were proposed in this pull request? This pr is a backport of apache#13638 for `branch-1.6`. ## How was this patch tested? Added the same test as apache#13638 modified for `branch-1.6`. Author: Takuya UESHIN <[email protected]> Closes apache#13668 from ueshin/issues/SPARK-15915_1.6. (cherry picked from commit cffc080)
What changes were proposed in this pull request?
This pr is a backport of #13638 for
branch-1.6.How was this patch tested?
Added the same test as #13638 modified for
branch-1.6.