[SPARK-14600][SQL] Push predicates through Expand #12496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @davies |
|
Test build #56225 has finished for PR 12496 at commit
|
|
|
||
| // the `groupByAttrs` has different meaning in `Expand.output`, it could be the original | ||
| // grouping expression or null, so here we create new instance of it. | ||
| val output = child.output ++ groupByAttrs.map(_.newInstance) :+ gid | ||
| Expand(projections, output, Project(child.output ++ groupByAliases, child)) |
There was a problem hiding this comment.
Do we still need this Project?
There was a problem hiding this comment.
Or we will evaluate the grouping expressions many times.
|
Test build #56315 has finished for PR 12496 at commit
|
|
LGTM, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-14600
This PR makes
Expand.outputhave different attributes from the grouping attributes produced by the underlyingProject, as they have different meaning, so that we can safely push down filter throughExpandHow was this patch tested?
existing tests.