[Minor][DOC] Fix nits in JavaStreamingTestExample #11821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @MLnick |
|
|
||
| long cntSignificant = rdd.filter(new Function<StreamingTestResult, Boolean>() { | ||
| boolean anySignificant = ! rdd.filter(new Function<StreamingTestResult, Boolean>() { |
There was a problem hiding this comment.
(No space after "!")
Looking good, thank you for indulging. The example is now about as close as possible to the scala version
There was a problem hiding this comment.
ok, the space is removed.
|
Agreed, LGTM pending Sean's comment. @srowen thanks for the catch, I'll not be too hasty next time :) |
|
Test build #53532 has finished for PR 11821 at commit
|
|
Test build #53533 has finished for PR 11821 at commit
|
|
Merged to master |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
## What changes were proposed in this pull request? Fix some nits discussed in apache#11776 (comment) use !rdd.isEmpty instead of rdd.count > 0 use static instead of AtomicInteger remove unneeded "throws Exception" ## How was this patch tested? manual tests Author: Zheng RuiFeng <[email protected]> Closes apache#11821 from zhengruifeng/je_fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix some nits discussed in #11776 (comment)
use !rdd.isEmpty instead of rdd.count > 0
use static instead of AtomicInteger
remove unneeded "throws Exception"
How was this patch tested?
manual tests