[SPARK-2218] rename Equals to EqualTo in Spark SQL expressions. #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build triggered. |
|
Merged build started. |
|
|
||
| // No cast expression introduced | ||
| project.transformAllExpressions { case c: Cast => | ||
| assert(false, "unexpected cast " + c) |
There was a problem hiding this comment.
fail(s"unexpected cast $c") would be more concise.
rxin
changed the title
| numEquals += 1 | ||
| e | ||
| } | ||
| assert(numEquals === 1) |
There was a problem hiding this comment.
I think this can be simplified to:
assert(project.collect { case e: EqualsTo => e }.size === 1)
|
LGTM :) |
|
Merged build triggered. |
|
Merged build started. |
Conflicts: sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetQuerySuite.scala
|
Merged build triggered. |
|
Merged build started. |
Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveTypeCoercionSuite.scala
|
Merged build finished. All automated tests passed. |
|
Merged build triggered. |
|
All automated tests passed. |
|
Merged build started. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15949/ |
|
Jenkins, retest this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Ok merging this in master & branch-1.0. |
asfgit
pushed a commit
that referenced
this pull request
Jun 20, 2014
Due to the existence of scala.Equals, it is very error prone to name the expression Equals, especially because we use a lot of partial functions and pattern matching in the optimizer. Note that this sits on top of #1144. Author: Reynold Xin <[email protected]> Closes #1146 from rxin/equals and squashes the following commits: f8583fd [Reynold Xin] Merge branch 'master' of github.com:apache/spark into equals 326b388 [Reynold Xin] Merge branch 'master' of github.com:apache/spark into equals bd19807 [Reynold Xin] Rename EqualsTo to EqualTo. 81148d1 [Reynold Xin] [SPARK-2218] rename Equals to EqualsTo in Spark SQL expressions. c4e543d [Reynold Xin] [SPARK-2210] boolean cast on boolean value should be removed. (cherry picked from commit 2f6a835) Signed-off-by: Reynold Xin <[email protected]>
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
Due to the existence of scala.Equals, it is very error prone to name the expression Equals, especially because we use a lot of partial functions and pattern matching in the optimizer. Note that this sits on top of apache#1144. Author: Reynold Xin <[email protected]> Closes apache#1146 from rxin/equals and squashes the following commits: f8583fd [Reynold Xin] Merge branch 'master' of github.com:apache/spark into equals 326b388 [Reynold Xin] Merge branch 'master' of github.com:apache/spark into equals bd19807 [Reynold Xin] Rename EqualsTo to EqualTo. 81148d1 [Reynold Xin] [SPARK-2218] rename Equals to EqualsTo in Spark SQL expressions. c4e543d [Reynold Xin] [SPARK-2210] boolean cast on boolean value should be removed.
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Due to the existence of scala.Equals, it is very error prone to name the expression Equals, especially because we use a lot of partial functions and pattern matching in the optimizer. Note that this sits on top of apache#1144. Author: Reynold Xin <[email protected]> Closes apache#1146 from rxin/equals and squashes the following commits: f8583fd [Reynold Xin] Merge branch 'master' of github.com:apache/spark into equals 326b388 [Reynold Xin] Merge branch 'master' of github.com:apache/spark into equals bd19807 [Reynold Xin] Rename EqualsTo to EqualTo. 81148d1 [Reynold Xin] [SPARK-2218] rename Equals to EqualsTo in Spark SQL expressions. c4e543d [Reynold Xin] [SPARK-2210] boolean cast on boolean value should be removed.
wangyum
pushed a commit
that referenced
this pull request
May 26, 2023
* [CARMEL-6381] Remove unnecessary sql metrics for UnionExec * Fix code style * Add ut * Fix ut
yaooqinn
added a commit
that referenced
this pull request
Sep 14, 2023
…pply api changes in UI ### What changes were proposed in this pull request? This PR is a follow-up of SPARK-45120 to cover the missing cases, and then fix test failures reported by SPARK-45150 It also brings back #42879 ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested with the excluded CI tests bellow ``` [info] ChromeUISeleniumSuite: Starting ChromeDriver 117.0.5938.62 (25a7172909a4cba7355365cf424d7d7eb35231f4-refs/branch-heads/5938{#1146}) on port 12624 Only local connections are allowed. Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe. ChromeDriver was started successfully. [info] - SPARK-31534: text for tooltip should be escaped (1 second, 979 milliseconds) [info] - SPARK-31882: Link URL for Stage DAGs should not depend on paged table. (683 milliseconds) [info] - SPARK-31886: Color barrier execution mode RDD correctly (304 milliseconds) [info] - Search text for paged tables should not be saved (1 second, 307 milliseconds) [info] Run completed in 6 seconds, 702 milliseconds. [info] Total number of tests run: 4 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ```` ### Was this patch authored or co-authored using generative AI tooling? no Closes #42907 from yaooqinn/SPARK-45150. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the existence of scala.Equals, it is very error prone to name the expression Equals, especially because we use a lot of partial functions and pattern matching in the optimizer.
Note that this sits on top of #1144.