-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] [ML] [Doc] Remove duplicated periods at the end of some sharedParam #11344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanboliang
changed the title
[] [] [] Clean up sharedParams
[Minor] [ML] [Doc] Clean up sharedParams
Feb 24, 2016
yanboliang
changed the title
[Minor] [ML] [Doc] Clean up sharedParams
[Minor] [ML] [Doc] Clean up dots at the end of some sharedParams
Feb 24, 2016
yanboliang
changed the title
[Minor] [ML] [Doc] Clean up dots at the end of some sharedParams
[Minor] [ML] [Doc] Cleanup dots at the end of some sharedParam
Feb 24, 2016
@yanboliang this isn't worth changing. The period isn't hurting anything |
Test build #51870 has finished for PR 11344 at commit
|
This was referenced Feb 24, 2016
Test build #51881 has finished for PR 11344 at commit
|
Jenkins, test this please. |
yanboliang
changed the title
[Minor] [ML] [Doc] Cleanup dots at the end of some sharedParam
[Minor] [ML] [Doc] Remove duplicated periods at the end of some sharedParam
Feb 25, 2016
Test build #51970 has finished for PR 11344 at commit
|
May not be worth it, but I think it's fine to fix. LGTM I'll merge this with master |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…aram ## What changes were proposed in this pull request? Remove duplicated periods at the end of some sharedParams in ScalaDoc, such as [here](https://github.com/apache/spark/pull/11344/files#diff-9edc669edcf2c0c7cf1efe4a0a57da80L367) cc mengxr srowen ## How was this patch tested? Documents change, no test. Author: Yanbo Liang <[email protected]> Closes apache#11344 from yanboliang/shared-cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove duplicated periods at the end of some sharedParams in ScalaDoc, such as here
cc @mengxr @srowen
How was this patch tested?
Documents change, no test.