Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Support transforming TreeNodes with Option children. #1074

Closed

Conversation

concretevitamin
Copy link
Contributor

Thanks goes to @marmbrus for his implementation.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15752/

@marmbrus
Copy link
Contributor

This test is failing because you made the TreeNode an inner class. An inner class is actually just syntactic sugar done by the compiler where there is an extra implicit constructor parameter to the class for the outer object. As a result, the contract that all of the argument to the TreeNode's constructor are either in productIterator or otherCopyArgs is broken.

Here's a fix: concretevitamin#1

@concretevitamin
Copy link
Contributor Author

Ah, this is tricky. Good to know and thanks for the fix.

On Friday, June 13, 2014, Michael Armbrust [email protected] wrote:

This test is failing because you made the TreeNode an inner class. An
inner class is actually just syntactic sugar done by the compiler where
there is an extra implicit constructor parameter to the class for the outer
object. As a result, the contract that all of the argument to the TreeNode's
constructor are either in productIterator or otherCopyArgs is broken.

Here's a fix: concretevitamin#1
concretevitamin#1


Reply to this email directly or view it on GitHub
#1074 (comment).

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15779/

@asfgit asfgit closed this in 269fc62 Jun 15, 2014
asfgit pushed a commit that referenced this pull request Jun 15, 2014
Thanks goes to @marmbrus for his implementation.

Author: Michael Armbrust <[email protected]>
Author: Zongheng Yang <[email protected]>

Closes #1074 from concretevitamin/option-treenode and squashes the following commits:

ef27b85 [Zongheng Yang] Merge pull request #1 from marmbrus/pr/1074
73133c2 [Michael Armbrust] TreeNodes can't be inner classes.
ab78420 [Zongheng Yang] Add a test.
2ccb721 [Michael Armbrust] Add support for transformation of optional children.

(cherry picked from commit 269fc62)
Signed-off-by: Michael Armbrust <[email protected]>
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
Thanks goes to @marmbrus for his implementation.

Author: Michael Armbrust <[email protected]>
Author: Zongheng Yang <[email protected]>

Closes apache#1074 from concretevitamin/option-treenode and squashes the following commits:

ef27b85 [Zongheng Yang] Merge pull request apache#1 from marmbrus/pr/1074
73133c2 [Michael Armbrust] TreeNodes can't be inner classes.
ab78420 [Zongheng Yang] Add a test.
2ccb721 [Michael Armbrust] Add support for transformation of optional children.
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Thanks goes to @marmbrus for his implementation.

Author: Michael Armbrust <[email protected]>
Author: Zongheng Yang <[email protected]>

Closes apache#1074 from concretevitamin/option-treenode and squashes the following commits:

ef27b85 [Zongheng Yang] Merge pull request apache#1 from marmbrus/pr/1074
73133c2 [Michael Armbrust] TreeNodes can't be inner classes.
ab78420 [Zongheng Yang] Add a test.
2ccb721 [Michael Armbrust] Add support for transformation of optional children.
wangyum pushed a commit that referenced this pull request May 26, 2023
* [CARMEL-6185] Expose row count for RepeatableIterator

* fix code style

* Fix code style

* Fix UT

* Update code

* Update code
udaynpusa pushed a commit to mapr/spark that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants