[SPARK-10386] [MLlib] PrefixSpanModel supports save/load #10664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanboliang
changed the title
|
Test build #49015 has finished for PR 10664 at commit
|
|
I'd like to get this into 2.0. Could you please fix the merge conflicts? Thanks! |
|
Test build #55193 has finished for PR 10664 at commit
|
|
@jkbradley I have resolved conflicts, this is ready for review now. Thanks! |
|
Taking a look now |
| try { | ||
| model.save(sc, path) | ||
| val newModel = PrefixSpanModel.load(sc, path) | ||
| val actual = newModel.freqSequences.collect() |
There was a problem hiding this comment.
I'd compare with the original model, not an expected result, here.
|
This looks good; I just had 1 comment |
|
Test build #55719 has finished for PR 10664 at commit
|
|
LGTM |
| * If the directory already exists, this method throws an exception. | ||
| */ | ||
| @Since("2.0.0") | ||
| override def save(sc: SparkContext, path: String): Unit = { |
There was a problem hiding this comment.
Not here, but it's needed for other algorithms (with local representations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrefixSpanModelsupportssave/load. It's similar with #9267.cc @jkbradley