Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-10359][PROJECT-INFRA] Use more random number in dev/test-dependencies.sh; fix version switching #10558

Closed
wants to merge 6 commits into from

Conversation

JoshRosen
Copy link
Contributor

This patch aims to fix another potential source of flakiness in the dev/test-dependencies.sh script.

@pwendell's original patch and my version used $(date +%s | tail -c6) to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead.

I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail.

@JoshRosen
Copy link
Contributor Author

/cc @rxin

@SparkQA
Copy link

SparkQA commented Jan 2, 2016

Test build #48589 has finished for PR 10558 at commit 8e86e9c.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Test failure was due to Python 3.

@SparkQA
Copy link

SparkQA commented Jan 2, 2016

Test build #48591 has finished for PR 10558 at commit 77a23bf.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 3, 2016

Test build #48594 has finished for PR 10558 at commit 0a6b120.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 3, 2016

Test build #2298 has finished for PR 10558 at commit 0a6b120.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 3, 2016

lgtm

On Saturday, January 2, 2016, Apache Spark QA [email protected]
wrote:

Test build #2298 has finished
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2298/consoleFull

for PR 10558 at commit 0a6b120
0a6b120
.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.


Reply to this email directly or view it on GitHub
#10558 (comment).

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 3, 2016

Test build #48595 has finished for PR 10558 at commit 0a6b120.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Aha! It looks like the code for resetting the version has a problem:

+ build/mvn --force -q versions:set '-DnewVersion=

OLD_VERSION isn't being set properly:

+ OLD_VERSION='
[WARNING] The POM for org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 is missing, no dependency information available

[WARNING] Failed to retrieve plugin descriptor for org.eclipse.m2e:lifecycle-mapping:1.0.0: Plugin org.eclipse.m2e:lifecycle-mapping:1.0.0 or one of its dependencies could not be resolved: Could not find artifact org.eclipse.m2e:lifecycle-mapping:jar:1.0.0 in central (https://repo1.maven.org/maven2)
2.0.0-SNAPSHOT'

@JoshRosen JoshRosen changed the title [SPARK-10359][PROJECT-INFRA] Use a more random suffix in dev/test-dependencies.sh [SPARK-10359][PROJECT-INFRA] Use more random number in dev/test-dependencies.sh; fix version switching Jan 3, 2016
@JoshRosen
Copy link
Contributor Author

Pushed a fix for the version issue, so I'm going to run this a few more times then will merge if it's passing.

@SparkQA
Copy link

SparkQA commented Jan 3, 2016

Test build #48596 has finished for PR 10558 at commit ae3d7a3.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 3, 2016

Test build #48599 has finished for PR 10558 at commit a2d59e5.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 3, 2016

Test build #48615 has finished for PR 10558 at commit a2d59e5.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jan 4, 2016

Test build #48640 has finished for PR 10558 at commit a2d59e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor Author

Merging now.

@asfgit asfgit closed this in 9fd7a2f Jan 4, 2016
@JoshRosen JoshRosen deleted the build-dep-tests-round-3 branch January 4, 2016 09:06
JoshRosen added a commit to JoshRosen/spark that referenced this pull request Jan 10, 2016
…dencies.sh; fix version switching

This patch aims to fix another potential source of flakiness in the `dev/test-dependencies.sh` script.

pwendell's original patch and my version used `$(date +%s | tail -c6)` to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead.

I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail.

Author: Josh Rosen <[email protected]>

Closes apache#10558 from JoshRosen/build-dep-tests-round-3.
JoshRosen added a commit to JoshRosen/spark that referenced this pull request Jan 10, 2016
…dencies.sh; fix version switching

This patch aims to fix another potential source of flakiness in the `dev/test-dependencies.sh` script.

pwendell's original patch and my version used `$(date +%s | tail -c6)` to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead.

I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail.

Author: Josh Rosen <[email protected]>

Closes apache#10558 from JoshRosen/build-dep-tests-round-3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants