-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-10359][PROJECT-INFRA] Use more random number in dev/test-dependencies.sh; fix version switching #10558
Conversation
/cc @rxin |
Test build #48589 has finished for PR 10558 at commit
|
Test failure was due to Python 3. |
Test build #48591 has finished for PR 10558 at commit
|
Test build #48594 has finished for PR 10558 at commit
|
Test build #2298 has finished for PR 10558 at commit
|
lgtm On Saturday, January 2, 2016, Apache Spark QA [email protected]
|
Jenkins, retest this please. |
Test build #48595 has finished for PR 10558 at commit
|
Aha! It looks like the code for resetting the version has a problem:
|
Pushed a fix for the version issue, so I'm going to run this a few more times then will merge if it's passing. |
Test build #48596 has finished for PR 10558 at commit
|
Test build #48599 has finished for PR 10558 at commit
|
Jenkins, retest this please. |
Test build #48615 has finished for PR 10558 at commit
|
Jenkins, retest this please. |
Test build #48640 has finished for PR 10558 at commit
|
Merging now. |
…dencies.sh; fix version switching This patch aims to fix another potential source of flakiness in the `dev/test-dependencies.sh` script. pwendell's original patch and my version used `$(date +%s | tail -c6)` to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead. I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail. Author: Josh Rosen <[email protected]> Closes apache#10558 from JoshRosen/build-dep-tests-round-3.
…dencies.sh; fix version switching This patch aims to fix another potential source of flakiness in the `dev/test-dependencies.sh` script. pwendell's original patch and my version used `$(date +%s | tail -c6)` to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead. I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail. Author: Josh Rosen <[email protected]> Closes apache#10558 from JoshRosen/build-dep-tests-round-3.
This patch aims to fix another potential source of flakiness in the
dev/test-dependencies.sh
script.@pwendell's original patch and my version used
$(date +%s | tail -c6)
to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead.I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail.